Merge pull request #2245 from WordPress/feature/enqueuedresources-bri…

…ng-back-try-catch
WordPress · May 28, 2023 · a328aff · a328aff
2 parents 6efe2f6 + 1dc9d7f
commit a328aff
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/WordPress/Sniffs/WP/EnqueuedResourcesSniff.php b/WordPress/Sniffs/WP/EnqueuedResourcesSniff.php
@@ -9,6 +9,7 @@
 
 namespace WordPressCS\WordPress\Sniffs\WP;
 
+use PHP_CodeSniffer\Exceptions\RuntimeException;
 use PHP_CodeSniffer\Util\Tokens;
 use PHPCSUtils\Tokens\Collections;
 use PHPCSUtils\Utils\TextStrings;
@@ -53,8 +54,13 @@ public function process_token( $stackPtr ) {
 		$end_ptr = $stackPtr;
 		$content = $this->tokens[ $stackPtr ]['content'];
 		if ( \T_INLINE_HTML !== $this->tokens[ $stackPtr ]['code'] ) {
-			$end_ptr = TextStrings::getEndOfCompleteTextString( $this->phpcsFile, $stackPtr );
-			$content = TextStrings::getCompleteTextString( $this->phpcsFile, $stackPtr );
+			try {
+				$end_ptr = TextStrings::getEndOfCompleteTextString( $this->phpcsFile, $stackPtr );
+				$content = TextStrings::getCompleteTextString( $this->phpcsFile, $stackPtr );
+			} catch ( RuntimeException $e ) {
+				// Parse error/live coding.
+				return;
+			}
 		}
 
 		if ( preg_match_all( '# rel=\\\\?[\'"]?stylesheet\\\\?[\'"]?#', $content, $matches, \PREG_OFFSET_CAPTURE ) > 0 ) {

diff --git a/WordPress/Tests/WP/EnqueuedResourcesUnitTest.1.inc b/WordPress/Tests/WP/EnqueuedResourcesUnitTest.1.inc
@@ -53,3 +53,6 @@ echo '<script type="text/javascript"
 // Test multi-line text string with multiple issues.
 echo '<link rel="stylesheet" href="https://someurl/somefile1.css"/>
 	<link rel="stylesheet" href="https://someurl/somefile2.css"/>';
+
+// Safeguard the handling of a particular type of parse error (forgotten concat operator).
+echo 'not a text we need to worry' 'about anyway, but we shouldn\'t see an uncaught runtime exception because of it';