Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about __FILE__ for page registration #86

Closed
1 task done
westonruter opened this issue Oct 11, 2013 · 0 comments · Fixed by #111
Closed
1 task done

Warn about __FILE__ for page registration #86

westonruter opened this issue Oct 11, 2013 · 0 comments · Fixed by #111
Assignees
@westonruter
Milestone
WordPress VIP Rules

Comments

@westonruter
Copy link
Member

  • Flag the presence of __FILE__ in add_menu_page(), add_submenu_page(), or any of the other admin menu functions.

Using __FILE__ for page registration #

When adding menus or registering your plugins, make sure that you use an unique handle or slug other than __FILE__ to ensure that you are not revealing system paths.
@ghost ghost assigned shadyvb Oct 26, 2013
shadyvb added a commit that referenced this issue Oct 27, 2013
@shadyvb
Warn about __FILE__ for page registration #86
691bba8
@ghost ghost assigned westonruter Oct 27, 2013
@shadyvb shadyvb mentioned this issue Oct 27, 2013
Merged
grappler pushed a commit to grappler/WordPress-Coding-Standards that referenced this issue Dec 17, 2016
@jrfnl @grappler
Add rule to prohibit the use of the backtick shell execution operator. (
07423e2 
WordPress#86)

Execution of shell commands should be discouraged. A number of the other commands along the same lines are discouraged via function sniffs, however, the backtick operator was so far ignored.

For this sniff to be added, the minimum PHPCS version needs to be upped as it has only just been added in the latest release.

See: squizlabs/PHP_CodeSniffer#1073
grappler pushed a commit to grappler/WordPress-Coding-Standards that referenced this issue Feb 10, 2017
@jrfnl @grappler
Add rule to prohibit the use of the backtick shell execution operator. (
70e3b57 
WordPress#86)

Execution of shell commands should be discouraged. A number of the other commands along the same lines are discouraged via function sniffs, however, the backtick operator was so far ignored.

For this sniff to be added, the minimum PHPCS version needs to be upped as it has only just been added in the latest release.

See: squizlabs/PHP_CodeSniffer#1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
None yet
Projects
None yet
Milestone
WordPress VIP Rules
Development

Successfully merging a pull request may close this issue.

Warn about __FILE__ for page registration WordPress/WordPress-Coding-Standards
2 participants
@westonruter @shadyvb