Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be compatible with PHP_CodeSniffer v3 #938

Closed
fulldecent opened this issue May 4, 2017 · 1 comment
Closed

Be compatible with PHP_CodeSniffer v3 #938

fulldecent opened this issue May 4, 2017 · 1 comment
Labels
Status: Duplicate

Comments

@fulldecent
Copy link
Contributor

Dependency on the old version is expressed here:

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/master/composer.json#L14

However a new version was just released here:

https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0

Therefore we are now depending on an old version.
fulldecent added a commit to fulldecent/WordPress-Coding-Standards that referenced this issue May 4, 2017
@fulldecent
Use latest PHP_CodeSniffer, fixes WordPress#938
112276d
@jrfnl
Copy link
Member

jrfnl commented May 4, 2017

Closing as duplicate of #718.

WPCS is currently not (yet) compatible with PHPCS 3.0.

@jrfnl jrfnl closed this as completed May 4, 2017
@jrfnl jrfnl mentioned this issue May 9, 2017
Closed
@westonruter westonruter mentioned this issue May 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fulldecent @jrfnl