Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1157/Proposal 2: rename sniffs #1242

Merged
merged 14 commits into from
Dec 13, 2017

Commits on Nov 26, 2017

  1. DirectDatabaseQuery: move sniff from VIP category to DB category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    59ff199 View commit details
    Browse the repository at this point in the history
  2. DirectDatabaseQuery: downgrade messages to warning

    The messages thrown by the sniff have been downgraded to warnings and the message text adjusted to make the sniff more generically usable.
    
    For the VIP ruleset, this change is undone via custom ruleset properties.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    4c98056 View commit details
    Browse the repository at this point in the history
  3. SlowDBQuery: move sniff from VIP category to DB category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    0630778 View commit details
    Browse the repository at this point in the history
  4. PreparedSQL: move sniff from WP category to DB category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    002d607 View commit details
    Browse the repository at this point in the history
  5. DontExtract: move sniff from VIP category to DB category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    a6315f2 View commit details
    Browse the repository at this point in the history
  6. NonceVerification: move sniff from CSRF category to Security category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    0b531e2 View commit details
    Browse the repository at this point in the history
  7. EscapeOutput: move sniff from XSS category to Security category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    b04e8ef View commit details
    Browse the repository at this point in the history
  8. PluginMenuSlug: move sniff from VIP category to Security category

    The original sniff class still exists, but extends the renamed sniff now.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    5f7d0b0 View commit details
    Browse the repository at this point in the history
  9. PluginMenuSlug: downgrade message to warning

    The message thrown by the sniff has been downgraded to a warning and the message text adjusted to make the sniff more generically usable.
    
    For the VIP ruleset, this change is undone via a custom ruleset property.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    4980804 View commit details
    Browse the repository at this point in the history
  10. ValidatedSanitizedInput: move sniff from VIP category to Security cat…

    …egory
    
    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    cad14c8 View commit details
    Browse the repository at this point in the history
  11. CronInterval: move sniff from VIP category to WP category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    52faccb View commit details
    Browse the repository at this point in the history
  12. CronInterval: downgrade message to warning

    The message thrown by the sniff has been downgraded to a warning and the message text adjusted to make the sniff more generically usable.
    
    For the VIP ruleset, this change is undone via a custom ruleset property.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    77e9086 View commit details
    Browse the repository at this point in the history
  13. TimezoneChange: move sniff from VIP category to WP category

    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    52ee644 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2017

  1. GlobalVariables: move sniff from Variables category to WP category an…

    …d rename
    
    The sniff has been renamed from `GlobalVariables` to `GlobalVariablesOverride` to make it easier to understand at one glance what the sniff is about.
    
    The original sniff class still exists, but extends the renamed sniff now.
    In addition, a deprecation warning will be thrown if this sniff is included directly by a custom ruleset.
    A deprecation warning will also be thrown if the sniff is included directly just to set custom properties.
    
    Note: if the sniff was explicitly **excluded** via a custom ruleset, no deprecation warning will be thrown and the exclusion will have no effect. The custom ruleset will need to be updated to use the new sniff name for the exclusion to be reinstated.
    jrfnl committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    0067724 View commit details
    Browse the repository at this point in the history