Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to separate coding standards and best practices to their own rulesets #1475

Closed
wants to merge 3 commits into from
Closed

Start to separate coding standards and best practices to their own rulesets #1475

wants to merge 3 commits into from

Conversation

javorszky
Copy link

Base ruleset is WordPress-Core.

Thinking:

  • is it something that is covered by PSR1 or PSR2? -> coding style
  • is it something that isn't WP specific, isn't covered by PSR1 or PSR2, but relates to how the code looks and other code styles may or may not have a rule to it? -> coding style
  • everything else is a best practice

Have a look at the files. I'll go through WordPress-Extra and separate the extras / overrides from that onto either of these. Not sure how to handle the layered approach to be honest.

Would a WordPress-Extra-CodingStyle and WordPress-Extra-BestPractices make sense that just imported the previous ones?

Won't that fragment the rulesets?

@jrfnl
Copy link
Member

jrfnl commented Aug 31, 2018

Hi @javorszky Thank you for your willingness to contribute and for this PR.

Unfortunately, I will close this PR at this time as this has been discussed several times before - see issues #740, #1067, #1157, #1269 - without consensus being reached.
I would kindly like to ask you to contribute to and continue the discussions in those issue(s). If and when consensus would be reached and this PR would be in line with it, we can always re-open the PR.

@jrfnl jrfnl closed this Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants