Fix EscapeOutput regression #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDGrimes
added a commit
that referenced
this pull request
Mar 2, 2015
…tput-regression Fix EscapeOutput regression causing closing parentheses to be reported as needing to be escaped.
|
@JDGrimes perfect! Works so much better now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the
EscapeOutputSniff, probably as part of #312, #314, #315, #316, or #317.The second two of the three OK lines added to this unit test are failing. It seems not adding a semicolon to the first instance causes the second OK line to croak, but the third OK line seems to fail regardless of prior semicolons.