Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for error fixing to ArrayDeclaration #378

Merged
merged 2 commits into from
May 20, 2015
Merged

Add support for error fixing to ArrayDeclaration #378

merged 2 commits into from
May 20, 2015

Commits on May 3, 2015

  1. Add support for error fixing to ArrayDeclaration 

    This basically synchronizes it with `Squiz.Arrays.ArrayDeclaration`.
The upstream version is similar, except that we exclude a few errors.
Unfortunately we have to actually comment out the code rather than just
using the upstream sniff and `<exclude>` in our ruleset, due to a bug
(squizlabs/PHP_CodeSniffer#582). (I’ve also included a fix for another
bug, squizlabs/PHP_CodeSniffer#584.) Because of this, we cannot yet
eliminate duplicated logic from this child sniff.

I think this pretty much maintains the previous behavior, except that I
have added a warning for extra whitespace at the edges of multiline
arrays.
    @JDGrimes
    JDGrimes committed May 3, 2015
    Configuration menu
    Copy the full SHA
    3ea49d2 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2015

  1. Convert warnings to errors

    @JDGrimes
    JDGrimes committed May 20, 2015
    Configuration menu
    Copy the full SHA
    e2c5160 View commit details
    Browse the repository at this point in the history