-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for version 0.11.0 #866
Conversation
0df27f5
to
3c259e0
Compare
We originally said release should be on a monthly basis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great work @jrfnl!
CHANGELOG.md
Outdated
- The `WordPress.Arrays.ArrayDeclaration` sniff has been split into two sniffs: `WordPress.Arrays.ArrayDeclaration` and `WordPress.Arrays.ArrayDeclarationSpacing` for better compatibility with PHPCS upstream. | ||
- The `WordPress.Arrays.ArrayDeclaration` sniff has been synced with the PHPCS upstream version to get the benefit of some bug fixes and improvements which had been made upstream since the sniff was originally copied over. | ||
- The `WordPress.VIP.FileSystemWritesDisallow`, `WordPress.VIP.TimezoneChange` and `WordPress.VIP.SessionFunctionsUsage` sniffs now extend the `WordPress_AbstractFunctionRestrictionsSniff`. | ||
- Property handling of custom properties set via a custom ruleset where the property is expected to be set in array format (`type=""array"`) has been made more lenient and will now also handle properties passed as a comma delimited lists correctly. This affects all customizable properties which expect array format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra quote in type=""array"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting that one. Fixed now.
Monthly might be too quick sometimes, depending on how active contribution is. But as long as there are a few significant changes at the end of the month, I think we should go ahead and drop a release. I just need to be better about actually setting aside the time to do it (sometimes easy, sometimes not). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not checked for what might be missing, but couldn't spot any issues with what's here. Really fantastic dedication to the project @jrfnl. Thank you.
3c259e0
to
095519a
Compare
Releases based on time often become quite forced. What about something along the lines of: if there are twenty (arbitrary number) or more merged PRs and no on-going PR-chains (like the recent one with all the internal changes building onto each other and having to be pulled one by one as they would conflict) ? |
FYI: I went through all the merged PRs, but I've grouped the entries for numerous PRs together where appropriate and - logically - not made separate entries for bugs in features which were freshly introduced in this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrfnl astonishingly impressive work 👏
095519a
to
fc61fc2
Compare
Ok, finished... & ready for review 🎉
Looking at the changelog now, I kind of think we may need to release new versions more often...