Maintain the Privacy Policy help notice location

[desrosj]

When using the classic editor, the Privacy Policy help notice location in 4.9.x (directly under the post title with the edit_form_after_title action hook) should be maintained.

Related: WordPress/gutenberg#11999, WordPress/gutenberg#11604, Trac-45057.

[azaozz]

@desrosj updated this after all changes in beta-1. The remove_action/add_action have to run only when $settings['replace'] || self::is_classic( $post_id ). Could you see if it works as expected?

[desrosj]

Tested this with the following conditions:

• 5.0 RC1 with Classic Editor activated (no Gutenberg plugin).
• 5.0 RC1 with both Classic Editor and Gutenberg activated.
• WordPress 4.9.8 with Gutenberg plugin and Classic Editor active.
• WordPress 4.9.8 with only the Classic Editor active (no Gutenberg plugin).

All scenarios correctly restored/preserved the notice location.

[youknowriad]

I wonder if we need to revert this because the admin notices support was removed from RC2

[desrosj]

@youknowriad This can't be reverted until r43920 is reverted in WordPress Core. Even then, It will be tricky and I think it's best to leave this in here in some form for backward compatibility.

Scenarios I think of are:

• Reverted of r43920 in 5.0.1, and the user does not update the Classic Editor plugin
• Revert this change in Classic Editor and user stays on a version of core less than the one with a revert of 443920.

I have this on my list to follow up on with a new issue when it becomes clearer.

[youknowriad]

Thanks for the clarification @desrosj just wanted to make sure it was not something we missed :)