Get rid of the isGrouped context as not really needed now image doesn…

…'t need to add any markup based on location
WordPress · Dec 17, 2020 · 0550bcc · 0550bcc
1 parent 36c2a01
commit 0550bcc
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 39 deletions.
diff --git a/packages/block-library/src/image/block.json b/packages/block-library/src/image/block.json
@@ -2,13 +2,7 @@
 	"apiVersion": 2,
 	"name": "core/image",
 	"category": "media",
-	"usesContext": [
-		"allowResize",
-		"isGrouped",
-		"linkTo",
-		"linkTarget",
-		"sizeSlug"
-	],
+	"usesContext": [ "allowResize", "linkTo", "linkTarget", "sizeSlug" ],
 	"attributes": {
 		"align": {
 			"type": "string"

diff --git a/packages/block-library/src/image/edit.js b/packages/block-library/src/image/edit.js
@@ -2,7 +2,7 @@
  * External dependencies
  */
 import classnames from 'classnames';
-import { get, omit, pick } from 'lodash';
+import { get, omit, pick, isEmpty } from 'lodash';
 
 /**
  * WordPress dependencies
@@ -94,7 +94,6 @@ export function ImageEdit( {
 		sizeSlug,
 		inhertedAttributes,
 	} = attributes;
-	const { isGrouped } = context;
 	const [ tempUrl, setTempUrl ] = useState();
 	const altRef = useRef();
 	useEffect( () => {
@@ -161,10 +160,9 @@ export function ImageEdit( {
 		}
 
 		// Check if default link setting, or the one inherited from parent block should be used.
-		let linkDestination =
-			isGrouped && context.linkTo
-				? context.linkTo
-				: attributes.linkDestination;
+		let linkDestination = context.linkTo
+			? context.linkTo
+			: attributes.linkDestination;
 
 		if ( ! linkDestination ) {
 			// Use the WordPress option to determine the proper default.
@@ -203,7 +201,7 @@ export function ImageEdit( {
 		}
 		mediaAttributes.href = href;
 
-		if ( isGrouped ) {
+		if ( ! isEmpty( context ) ) {
 			const parentSizeAttributes = getImageSizeAttributes(
 				media,
 				context.sizeSlug

diff --git a/packages/block-library/src/image/image.js b/packages/block-library/src/image/image.js
@@ -85,13 +85,20 @@ export default function Image( {
 } ) {
 	const captionRef = useRef();
 	const prevUrl = usePrevious( url );
-	const { allowResize = true, isGrouped = false } = context;
+	const {
+		allowResize = true,
+		linkTo: parentLinkDestination,
+		sizeSlug: parentSizeSlug,
+	} = context;
 	const image = useSelect(
 		( select ) => {
 			const { getMedia } = select( 'core' );
-			return id && ( isSelected || isGrouped ) ? getMedia( id ) : null;
+			return id &&
+				( isSelected || parentLinkDestination || parentSizeSlug )
+				? getMedia( id )
+				: null;
 		},
-		[ id, isSelected, isGrouped ]
+		[ id, isSelected, parentLinkDestination ]
 	);
 	const {
 		imageEditing,

diff --git a/packages/block-library/src/image/use-parent-attributes.js b/packages/block-library/src/image/use-parent-attributes.js
@@ -24,50 +24,43 @@ export default function useParentAttributes(
 	setAttributes
 ) {
 	const {
-		isGrouped,
 		linkTo: parentLinkDestination,
 		linkTarget: parentLinkTarget,
 		sizeSlug: parentSizeSlug,
 	} = context;
 
 	useEffect( () => {
-		if ( ! isGrouped ) {
+		if ( ! inheritedAttributes.linkDestination ) {
 			return;
 		}
-		if ( inheritedAttributes.linkDestination && image ) {
+		if ( image ) {
 			const href = getUrl( image, parentLinkDestination );
 			setAttributes( {
 				href,
 				linkDestination: parentLinkDestination,
 			} );
 		}
-	}, [ image, parentLinkDestination, isGrouped ] );
+	}, [ image, parentLinkDestination ] );
 
 	useEffect( () => {
-		if ( ! isGrouped ) {
+		if ( ! inheritedAttributes.linkTarget ) {
 			return;
 		}
-		if ( inheritedAttributes.linkTarget ) {
-			setAttributes( {
-				linkTarget: parentLinkTarget,
-			} );
-		}
-	}, [ parentLinkTarget, isGrouped ] );
+
+		setAttributes( {
+			linkTarget: parentLinkTarget,
+		} );
+	}, [ parentLinkTarget ] );
 
 	useEffect( () => {
-		if ( ! isGrouped ) {
+		if ( ! inheritedAttributes.sizeSlug ) {
 			return;
 		}
 
-		if ( inheritedAttributes.sizeSlug ) {
-			const sizeAttributes = getImageSizeAttributes(
-				image,
-				parentSizeSlug
-			);
+		const sizeAttributes = getImageSizeAttributes( image, parentSizeSlug );
 
-			setAttributes( {
-				...sizeAttributes,
-			} );
-		}
-	}, [ parentSizeSlug, isGrouped ] );
+		setAttributes( {
+			...sizeAttributes,
+		} );
+	}, [ parentSizeSlug ] );
 }