Skip to content

Commit

Permalink
DataViews: Fix patterns, templates and template parts pagination `z-i…
Browse files Browse the repository at this point in the history 
…ndex` (#58965)

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: miksansegundo <miguelsansegundo@git.wordpress.org>
  • Loading branch information
@ntsekouras @t-hamano
@jameskoster @annezazu @miksansegundo
6 people committed Feb 13, 2024
1 parent 7bfaf2c commit 0c6f3cb
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/base-styles/_z-index.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ $z-layers: (
".edit-site-page-header": 2,
".edit-site-page-content": 1,
".edit-site-patterns__header": 2,
".edit-site-patterns__grid-pagination": 2,
".edit-site-patterns__dataviews-list-pagination": 2,
".edit-site-templates__dataviews-list-pagination": 2,
".edit-site-layout__canvas-container": 2,
".edit-site-layout__sidebar": 1,
".edit-site-layout__canvas-container.is-resizing::after": 100,
Expand Down
4 changes: 4 additions & 0 deletions packages/edit-site/src/components/page-patterns/style.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@
text-overflow: ellipsis;
color: inherit;
}

.dataviews-pagination {
z-index: z-index(".edit-site-patterns__dataviews-list-pagination");
}
}

.dataviews-action-modal__duplicate-pattern {
Expand Down
1 change: 1 addition & 0 deletions packages/edit-site/src/components/page-templates-template-parts/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ export default function PageTemplatesTemplateParts( { postType } ) {

return (
<Page
className="edit-site-page-template-template-parts-dataviews"
title={
postType === TEMPLATE_POST_TYPE
? __( 'Templates' )
Expand Down
6 changes: 6 additions & 0 deletions packages/edit-site/src/components/page-templates-template-parts/style.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,9 @@
.page-templates-description {
white-space: normal;
}

.edit-site-page-template-template-parts-dataviews {
.dataviews-pagination {
z-index: z-index(".edit-site-templates__dataviews-list-pagination");
}
}

1 comment on commit 0c6f3cb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 0c6f3cb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7889116569
📝 Reported issues:

Please sign in to comment.