Add comprehensive unit tests for REST search controller and fix bugs …

…detected by tests.
WordPress · May 5, 2018 · 311413e · 311413e
1 parent d80560f
commit 311413e
Show file tree

Hide file tree

Showing 2 changed files with 407 additions and 3 deletions.
diff --git a/lib/class-wp-rest-search-controller.php b/lib/class-wp-rest-search-controller.php
@@ -243,7 +243,12 @@ public function get_items( $request ) {
 	public function check_read_permission( $post ) {
 
 		// Is the post readable?
-		if ( 'publish' === $post->post_status || current_user_can( $post_type->cap->read_post, $post->ID ) ) {
+		if ( 'publish' === $post->post_status ) {
+			return true;
+		}
+
+		$post_type = get_post_type_object( $post->post_type );
+		if ( current_user_can( $post_type->cap->read_post, $post->ID ) ) {
 			return true;
 		}
 
@@ -790,7 +795,7 @@ protected function get_allowed_post_stati() {
 		$post_stati = get_post_stati( array(
 			'public'   => true,
 			'internal' => false,
-		) );
+		), 'objects' );
 
 		$post_stati['inherit'] = get_post_status_object( 'inherit' );
 
@@ -811,7 +816,7 @@ protected function get_allowed_post_types( $editable = false ) {
 		$post_types = get_post_types( array(
 			'public'       => true,
 			'show_in_rest' => true,
-		) );
+		), 'objects' );
 
 		if ( $editable ) {
 			$allowed = array();