Rich text: remove is-selected class (#19822)

* Rich text: prefix is-selected class * Adjust more cases * Remove the class
WordPress · Jan 23, 2020 · 4ae2c15 · 4ae2c15
1 parent 0de9e37
commit 4ae2c15
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 18 deletions.
diff --git a/packages/block-editor/src/components/rich-text/index.js b/packages/block-editor/src/components/rich-text/index.js
@@ -386,7 +386,6 @@ class RichTextWrapper extends Component {
 				onSelectionChange={ onSelectionChange }
 				tagName={ tagName }
 				className={ classnames( classes, className, {
-					'is-selected': originalIsSelected,
 					'keep-placeholder-on-focus': keepPlaceholderOnFocus,
 				} ) }
 				placeholder={ placeholder }

diff --git a/packages/block-editor/src/components/rich-text/style.scss b/packages/block-editor/src/components/rich-text/style.scss
@@ -16,15 +16,6 @@
 		font-size: inherit; // This is necessary to override upstream CSS.
 	}
 
-	&:focus {
-		// Removes outline added by the browser.
-		outline: none;
-
-		*[data-rich-text-format-boundary] {
-			border-radius: 2px;
-		}
-	}
-
 	[data-rich-text-placeholder] {
 		pointer-events: none;
 	}
@@ -36,9 +27,17 @@
 		opacity: 0.62;
 	}
 
-	// Could be unset for individual rich text instances.
-	&.is-selected:not(.keep-placeholder-on-focus) [data-rich-text-placeholder]::after {
-		display: none;
+	&:focus {
+		// Removes outline added by the browser.
+		outline: none;
+
+		[data-rich-text-format-boundary] {
+			border-radius: 2px;
+		}
+
+		&:not(.keep-placeholder-on-focus) [data-rich-text-placeholder]::after {
+			display: none;
+		}
 	}
 }
 

diff --git a/packages/block-library/src/navigation-link/editor.scss b/packages/block-library/src/navigation-link/editor.scss
@@ -50,10 +50,6 @@
 	.wp-block-navigation-link__submenu-icon {
 		margin-left: 4px;
 	}
-
-	.block-editor-rich-text__editable.is-selected:not(.keep-placeholder-on-focus):not(:focus) [data-rich-text-placeholder]::after {
-		display: inline-block;
-	}
 }
 
 [data-type="core/navigation-link"] {

diff --git a/packages/e2e-tests/specs/editor/blocks/navigation.test.js b/packages/e2e-tests/specs/editor/blocks/navigation.test.js
@@ -59,7 +59,7 @@ async function updateActiveNavigationLink( { url, label } ) {
 	}
 
 	if ( label ) {
-		await page.click( '.wp-block-navigation-link__label.is-selected' );
+		await page.click( '.is-selected .wp-block-navigation-link__label' );
 
 		// Ideally this would be `await pressKeyWithModifier( 'primary', 'a' )`
 		// to select all text like other tests do.