Skip to content

Commit

Permalink
Components: fix useCx story to satisfy exhaustive-deps eslint rule (
Browse files Browse the repository at this point in the history
#45614)

* move `eslint-ignore-*` to the correct line

* update CHANGELOG.md
  • Loading branch information
flootr committed Nov 9, 2022
1 parent 18b64f5 commit 5411c05
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- `withNotices`: Update to pass `exhaustive-deps` eslint rule ([#45530](https://github.com/WordPress/gutenberg/pull/45530)).
- `ItemGroup`: Update to pass `exhaustive-deps` eslint rule ([#45531](https://github.com/WordPress/gutenberg/pull/45531)).
- `Draggable`: Convert to TypeScript ([#45471](https://github.com/WordPress/gutenberg/pull/45471)).
- `useCx`: fix story to satisfy the `react-hooks/exhaustive-deps` eslint rule ([#45614](https://github.com/WordPress/gutenberg/pull/45614))

### Experimental

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/utils/hooks/stories/use-cx.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ const Example = ( { serializedStyles, children } ) => {
const ExampleWithUseMemoWrong = ( { serializedStyles, children } ) => {
const cx = useCx();
// Wrong: using 'useMemo' without adding 'cx' to the dependency list.
// eslint-disable-next-line react-hooks/exhaustive-deps
const classes = useMemo(
() => cx( serializedStyles ),
// eslint-disable-next-line react-hooks/exhaustive-deps
[ serializedStyles ]
);
return <span className={ classes }>{ children }</span>;
Expand Down

0 comments on commit 5411c05

Please sign in to comment.