ESLint plugin: Enable wp global by default in the recommended config

WordPress · Aug 5, 2019 · 5d78e9b · 5d78e9b
1 parent e0d2f4e
commit 5d78e9b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -22,6 +22,9 @@ module.exports = {
 		'plugin:@wordpress/eslint-plugin/recommended',
 		'plugin:jest/recommended',
 	],
+	globals: {
+		wp: 'off',
+	},
 	rules: {
 		'@wordpress/react-no-unsafe-timeout': 'error',
 		'no-restricted-syntax': [
@@ -112,9 +115,9 @@ module.exports = {
 				browser: true,
 			},
 			globals: {
-				browser: true,
-				page: true,
-				wp: true,
+				browser: 'readonly',
+				page: 'readonly',
+				wp: 'readonly',
 			},
 		},
 	],

diff --git a/packages/eslint-plugin/CHANGELOG.md b/packages/eslint-plugin/CHANGELOG.md
@@ -7,6 +7,7 @@
 ### New Features
 
 - New Rule: [`@wordpress/no-unguarded-get-range-at`](https://github.com/WordPress/gutenberg/blob/master/packages/eslint-plugin/docs/rules/no-unguarded-get-range-at.md)
+- Enable `wp` global by default in the `recommended` config.
 
 ## 2.4.0 (2019-08-05)
 

diff --git a/packages/eslint-plugin/configs/recommended.js b/packages/eslint-plugin/configs/recommended.js
@@ -12,5 +12,6 @@ module.exports = {
 	globals: {
 		window: true,
 		document: true,
+		wp: 'readonly',
 	},
 };