Address feedback

WordPress · Feb 20, 2024 · 67b6b53 · 67b6b53
1 parent feab691
commit 67b6b53
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/block-library/src/list-item/hooks/use-indent-list-item.js b/packages/block-library/src/list-item/hooks/use-indent-list-item.js
@@ -61,5 +61,7 @@ export default function useIndentListItem( clientId ) {
 				clonedBlocks[ clonedBlocks.length - 1 ].clientId
 			);
 		}
+
+		return true;
 	}, [ clientId ] );
 }
diff --git a/packages/block-library/src/list-item/hooks/use-outdent-list-item.js b/packages/block-library/src/list-item/hooks/use-outdent-list-item.js
@@ -93,5 +93,7 @@ export default function useOutdentListItem() {
 				removeBlock( parentListId, shouldSelectParent );
 			}
 		} );
+
+		return true;
 	}, [] );
 }
diff --git a/packages/block-library/src/list-item/hooks/use-space.js b/packages/block-library/src/list-item/hooks/use-space.js
@@ -40,14 +40,17 @@ export default function useSpace( clientId ) {
 					selectionStart.offset === 0 &&
 					selectionEnd.offset === 0
 				) {
-					event.preventDefault();
 					if ( shiftKey ) {
 						// Note that backspace behaviour in defined in onMerge.
 						if ( keyCode === TAB ) {
-							outdentListItem();
+							if ( outdentListItem() ) {
+								event.preventDefault();
+							}
 						}
 					} else if ( getBlockIndex( clientId ) !== 0 ) {
-						indentListItem();
+						if ( indentListItem() ) {
+							event.preventDefault();
+						}
 					}
 				}
 			}