Skip to content

Commit

Permalink
Add inline comment to remind updating package name
Browse files Browse the repository at this point in the history
This comment will avoid forgetting about updating the package name in all places needed.
  • Loading branch information
fluiddot committed Jul 25, 2023
1 parent ced1fc9 commit 67ca6bd
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ group='org.wordpress-mobile.gutenberg-mobile'
def buildAssetsFolder = 'build/assets'

android {
// IMPORTANT: Any updates to the namespace should be reflected in
// the `package` attribute of the main `AndroidManifest.xml` file.
// File reference: `react-native-bridge/android/react-native-bridge/src/main/AndroidManifest.xml`
namespace "org.wordpress.mobile.ReactNativeGutenbergBridge"

compileSdkVersion 33
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@

<!--
IMPORTANT: Any updates to the package name should be reflected in
the `namespace` property of the `build.gradle` file.
File reference: `react-native-bridge/android/react-native-bridge/build.gradle`
-->
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="org.wordpress.mobile.ReactNativeGutenbergBridge">

<queries>
Expand Down
3 changes: 3 additions & 0 deletions packages/react-native-editor/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ def reactNativeArchitectures() {
}

android {
// IMPORTANT: Any updates to the namespace should be reflected in
// the `package` attribute of the main `AndroidManifest.xml` file.
// File reference: `react-native-editor/android/app/src/main/AndroidManifest.xml`
namespace "com.gutenberg"
ndkVersion rootProject.ext.ndkVersion

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
<!--
IMPORTANT: Any updates to the package name should be reflected in
the `namespace` property of the `build.gradle` file.
File reference: `react-native-editor/android/app/build.gradle`
-->
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.gutenberg">

<uses-permission android:name="android.permission.INTERNET" />
Expand Down

0 comments on commit 67ca6bd

Please sign in to comment.