Skip to content

Commit

Permalink
Adds correct escaping for urls (#17932)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Welcher authored and hypest committed Nov 4, 2019
1 parent 123fa39 commit 70986bd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/block-library/src/social-link/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function render_core_social_link( $attributes ) {
}

$icon = core_social_link_get_icon( $site );
return '<li class="wp-social-link wp-social-link-' . $site . '"><a href="' . esc_attr( $url ) . '"> ' . $icon . '</a></li>';
return '<li class="wp-social-link wp-social-link-' . $site . '"><a href="' . esc_url( $url ) . '"> ' . $icon . '</a></li>';
}

/**
Expand Down

0 comments on commit 70986bd

Please sign in to comment.