Block API: Deprecate id prop in favor of clientId (#7669)

docs/reference/deprecated.md

@@ -4,6 +4,7 @@ Gutenberg's deprecation policy is intended to support backwards-compatibility fo
 
  - `focusOnMount` prop in the `Popover` component has been changed from `Boolean`-only to an enum-style property that accepts `"firstElement"`, `"container"`, or `false`. Please convert any `<Popover focusOnMount />` usage to `<Popover focusOnMount="firstElement" />`.
  - `wp.utils.keycodes` utilities are removed. Please use `wp.keycodes` instead.
+ - Block `id` prop in `edit` function removed. Please use block `clientId` prop instead.
 
 ## 3.3.0
 

edit-post/index.js

@@ -4,6 +4,7 @@
 import { registerCoreBlocks } from '@wordpress/core-blocks';
 import { render, unmountComponentAtNode } from '@wordpress/element';
 import { dispatch } from '@wordpress/data';
+import deprecated from '@wordpress/deprecated';
 
 /**
  * Internal dependencies
@@ -53,6 +54,14 @@ export function initializeEditor( id, postType, postId, settings, overridePost )
 	const target = document.getElementById( id );
 	const reboot = reinitializeEditor.bind( null, postType, postId, target, settings, overridePost );
 
+	// Global deprecations which cannot otherwise be injected into known usage.
+	deprecated( 'block `id` prop in `edit` function', {
+		version: '3.4',
+		alternative: 'block `clientId` prop',
+		plugin: 'Gutenberg',
+		hint: 'This is a global warning, shown regardless of whether blocks exist using the deprecated prop.',
+	} );
+
 	registerCoreBlocks();
 
 	dispatch( 'core/nux' ).triggerGuide( [

editor/components/block-list/block.js

@@ -534,6 +534,7 @@ export class BlockListBlock extends Component {
 								insertBlocksAfter={ isLocked ? undefined : this.insertBlocksAfter }
 								onReplace={ isLocked ? undefined : onReplace }
 								mergeBlocks={ isLocked ? undefined : this.mergeBlocks }
+								clientId={ uid }
 								id={ uid }
 								isSelectionEnabled={ this.props.isSelectionEnabled }
 								toggleSelection={ this.props.toggleSelection }