Skip to content

Commit

Permalink
Added missing left and right placement positions
Browse files Browse the repository at this point in the history
  • Loading branch information
@bfintal
bfintal committed Jun 30, 2023
1 parent 4314ee4 commit ced43d5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/components/src/popover/utils.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ const POSITION_TO_PLACEMENT: Record<
> = {
bottom: 'bottom',
top: 'top',
left: 'left',

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Puppeteer - 2 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Playwright - 3 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Puppeteer - 1 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Playwright - 1 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Playwright - 2 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 7.4 (WP 6.1.3) on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 7.4 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 8.1 on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 8.0 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 5.6 (WP 6.1.3) on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 8.1 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 7.0 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 8.2 on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Playwright - 4 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 8.2 (WP 6.1.3) on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 7.3 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 7.1 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 7.3 on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 5.6 on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 5.6 multisite on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / PHP 8.0 on ubuntu-latest 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Puppeteer - 3 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / Build Release Artifact 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.

Check failure on line 23 in packages/components/src/popover/utils.ts

View workflow job for this annotation

GitHub Actions / All 

Type '{ bottom: "bottom"; top: "top"; left: string; right: string; 'middle left': "left"; 'middle right': "right"; 'bottom left': "bottom-end"; 'bottom center': "bottom"; 'bottom right': "bottom-start"; 'top left': "top-end"; ... 39 more ...; 'middle center top': "bottom"; }' is not assignable to type 'Record<NonNullable<PositionYAxis | "bottom left" | "bottom right" | "bottom center" | "top left" | "top right" | "top center" | "middle left" | "middle right" | "middle center" | ... 36 more ... | undefined>, NonNullable<...>>'.
right: 'right',
'middle left': 'left',
'middle right': 'right',
'bottom left': 'bottom-end',
Expand Down

0 comments on commit ced43d5

Please sign in to comment.