-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ComboboxControl: Convert to TypeScript (#47581)
* ComboboxControl: Rename file * Remove tabIndex in BaseControl It doesn't do anything * ComboboxControl: Add types * Mark `value` prop as optional This definitely works with the initial value undefined, as seen in the readme code snippet and in unit tests. * Convert tests * Fixup * Convert stories * Remove from tsconfig * Add changelog * Add main JSDoc * Make code snippets more concise * Add code comment for empty string `value` * Show code snippets * Fix bug in Storybook * Add explicit default value * Fixup
- Loading branch information
Showing
9 changed files
with
296 additions
and
382 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
dc32380
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in dc32380.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4107417090
📝 Reported issues:
specs/editor/various/multi-block-selection.test.js
specs/editor/various/block-hierarchy-navigation.test.js