Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine "Calendar Help" and "Close" buttons in Datepicker #10621

Closed
tofumatt opened this issue Oct 15, 2018 · 0 comments · Fixed by #22176
Closed

Combine "Calendar Help" and "Close" buttons in Datepicker #10621

tofumatt opened this issue Oct 15, 2018 · 0 comments · Fixed by #22176
Assignees
@earnjam
Labels
[Package] Date /packages/date [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@tofumatt
Copy link
Member

Instead of conditionally rendering the "help" and "close" buttons of the datepicker, we could render one button as a "show/hide help" button as mentioned in #7621 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@earnjam earnjam

Labels
[Package] Date /packages/date [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combine Calendar Help and Close buttons in DateTimePicker WordPress/gutenberg
2 participants
@tofumatt @earnjam