Combine Calendar Help and Close buttons in DateTimePicker #22176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earnjam
added
[Type] Enhancement
earnjam
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
|
Size Change: -55 B (0%) Total Size: 822 kB
ℹ️ View Unchanged
|
karmatosed
approved these changes
May 15, 2020
youknowriad
approved these changes
May 18, 2020
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging #20914 and then browsing old issues, I came across #10621.
This is a quick fix that combines the separately rendered help/close buttons into a single toggle. It preserves focus when toggling the help text and is always rendered. This also resolves #21098
Fixes: #10621, #21098
Screenshots
I have a slight design change here, so I'm also flagging
Needs Design Feedbackto get some thoughts. Basically since it becomes a toggle I'm keeping it in the same location within the window. It's also retaining more of the standard button/link appearance to make it clear that it's a button. I couldn't find any original designs for this item in its current form. Found one older one with a regular style bordered button, but none as a link.Old:
New
