Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all PHP code from the Gutenberg plugin #10656

Closed
5 tasks
danielbachhuber opened this issue Oct 16, 2018 · 5 comments
Closed
5 tasks

Remove all PHP code from the Gutenberg plugin #10656

danielbachhuber opened this issue Oct 16, 2018 · 5 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@danielbachhuber
Copy link
Member

After WP 5.0 is released and the Gutenberg plugin's minimum-supported version is 5.0, we should remove all PHP code from the plugin. This includes, but isn't limited to:

  • WP_Block_Type_Registry, WP_Block_Type
  • WP_REST_Autosaves_Controller
  • WP_REST_Block_Renderer_Controller, WP_REST_Blocks_Controller
  • WP_REST_Post_Search_Handler, WP_REST_Search_Controller, WP_REST_Search_Handler.
  • lib/rest-api.php

We need to keep this PHP code in Gutenberg in the interim, so it's still possible to install Gutenberg on a 4.9.x installation.

@cristianozanca
Copy link

Fatal error: Cannot declare class WP_REST_Search_Controller`
This forced me to remove Gutenberg , wp-admin couldn't be accessed

@cristianozanca
Copy link

Fatal error: Cannot declare class WP_REST_Search_Controller, because the name is already in use in /var/www/mywordpress/wp-content/plugins/gutenberg/lib/class-wp-rest-search-controller.php on line 0

@danielbachhuber
Copy link
Member Author

@altrovideo Are you running the 5.0 branch? If so, you'll need to wait for Gutenberg 4.1 to land as it has the code that conditionally loads these classes #10531

@cristianozanca
Copy link

cristianozanca commented Oct 18, 2018

Yes I'm running WP 5.0 nightly build, I'll wait for Gutenberg 4.1, Thanks @danielbachhuber

@danielbachhuber
Copy link
Member Author

Closing in favor of #11015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants