Remove permalink_template and generated_slug attributes from rest_prepare_{$post_type} hook. - Moved it to core.

[rahulsprajapati]

We have moved permalink_template and generated_slug attributes to Posts controller in Core.
ref: https://core.trac.wordpress.org/ticket/45017 ( ready to commit and test )

Once this is merge to core we won't be needing this filter.

gutenberg/lib/rest-api.php

Line 287 in 3e53873

add_filter( "rest_prepare_{$post_type}", 'gutenberg_add_permalink_template_to_posts', 10, 3 );

gutenberg/lib/rest-api.php

Lines 191 to 217 in 3e53873

	/**
	* Add a permalink template to posts in the post REST API response.
	*
	* @see https://core.trac.wordpress.org/ticket/45017
	*
	* @param WP_REST_Response $response WP REST API response of a post.
	* @param WP_Post $post The post being returned.
	* @param WP_REST_Request $request WP REST API request.
	* @return WP_REST_Response Response containing the permalink_template.
	*/
	function gutenberg_add_permalink_template_to_posts( $response, $post, $request ) {
	if ( 'edit' !== $request['context'] ) {
	return $response;
	}
	if ( ! function_exists( 'get_sample_permalink' ) ) {
	require_once ABSPATH . '/wp-admin/includes/post.php';
	}
	$sample_permalink = get_sample_permalink( $post->ID, $post->post_title, '' );
	$response->data['permalink_template'] = $sample_permalink[0];
	$response->data['generated_slug'] = $sample_permalink[1];
	return $response;
	}

[Soean]

We can remove this filter, if Gutenberg requires WordPress >= 5.0. Maybe we should add a milestone?

[rahulsprajapati]

We can remove this filters if Gutenberg requires WordPress >= 5.0. Maybe we should add a milestone?

sure, it just the core ticket is tagged to 5.0 Milestone.

[danielbachhuber]

Before WordPress 5.0 ships, lib/rest-api.php will be removed entirely, so this issue will be taken care of with that.

However, once the patch in https://core.trac.wordpress.org/ticket/45017 lands, I'd like to update the filter in lib/rest-api.php to only fire on older versions of WordPress, such that Gutenberg uses the code in core for WordPress nightly builds and trunk.

[rahulsprajapati]

Raise this PR #10408 to test the code in the core for WordPress nightly builds and trunk.

[danielbachhuber]

test the code in the core for WordPress nightly builds and trunk.

Holding off on this for a few weeks: #10408 (comment)

[danielbachhuber]

Closing in favor of #10656