Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Publish prompts on page editor refer to "post" while it should be "page" #10750

Closed
arunsathiya opened this issue Oct 18, 2018 · 7 comments · Fixed by #11009 · May be fixed by monzerfoda/gutenberg#18
Closed

Enhancement: Publish prompts on page editor refer to "post" while it should be "page" #10750

arunsathiya opened this issue Oct 18, 2018 · 7 comments · Fixed by #11009 · May be fixed by monzerfoda/gutenberg#18
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Bug An existing feature does not function as intended
Milestone

Comments

@arunsathiya
Copy link
Contributor

Pre-publish prompt

🚨 Starting at a page editor, on clicking the Publish button at the top right, one can notice this text Double-check your settings, then use the button to publish your post. as a pre-publish prompt. This can be improved to Double-check your settings, then use the button to publish your page.

screen shot 2018-10-18 at 21 58 46

Result post publish/update

🚨 On a similar note, after publishing the page, it can be noticed that the result reads Post published! View post which can be updated to Page published! View page

✅ It can also be noticed that the View page button on the right is as expected.

screen shot 2018-10-18 at 22 03 03

🚨 Same can be said for updates made to a page.

screen shot 2018-10-18 at 22 08 06

@GlennMartin1
Copy link

Set to be fixed in upcoming 4.1 release.

@Soean
Copy link
Member

Soean commented Oct 18, 2018

The pre-publish prompt Double-check your settings, then use the button to publish your post. still is an issue in 4.1.

@Soean Soean added the [Type] Bug An existing feature does not function as intended label Oct 18, 2018
@Soean Soean added this to the WordPress 5.0 milestone Oct 18, 2018
@Soean Soean added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 18, 2018
@danielbachhuber
Copy link
Member

The pre-publish prompt Double-check your settings, then use the button to publish your post. still is an issue in 4.1.

We may want to re-evaluate Double-check your settings, then use the button to publish your post. as a string, as every custom post type will need to define it. Doing so seems less than ideal.

@bobbingwide
Copy link
Contributor

Meanwhile, in the Tips it's the other way around. I'm editing a post and the tips talk about page.

You’ll find more settings for your page and blocks in the sidebar. Click “Settings” to open it.

Click “Preview” to load a preview of this page, so you can make sure you’re happy with your blocks.

@swissspidy
Copy link
Member

Doing so seems less than ideal.

Agreed. What about something more general like Double-check your settings, then use the button to publish your content.?

@swissspidy swissspidy added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 21, 2018
@youknowriad youknowriad added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Oct 21, 2018
@sarahmonster
Copy link
Member

Making that string a bit more vague might be the right call here. There's definitely an opportunity to reduce awkwardness. We probably don't need to tell people to use a button (or if we do, we should consider improving the interface so it's more clear!)

We'll also need to reconsider: Your post will be published at the specified date and time. which suffers from the same issue.

What about instead:

Double-check your settings before publishing.
and
Your work will be published at the specified date and time.

@kristastevens
Copy link

Hello! Answering the copy review bat signal...

Since this phrase is used in multiple context, I agree that a more generic approach would be best. I love what @sarahmonster proposes above:

Double-check your settings before publishing.
and
Your work will be published at the specified date and time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Bug An existing feature does not function as intended
Projects
None yet
9 participants