Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post date should not be updated when post is set "pending review" #13176

Closed
davisshaver opened this issue Jan 3, 2019 · 2 comments · Fixed by #13178
Closed

Post date should not be updated when post is set "pending review" #13176

davisshaver opened this issue Jan 3, 2019 · 2 comments · Fixed by #13178
Labels
[Feature] Saving Related to saving functionality

Comments

@davisshaver
Copy link
Contributor

davisshaver commented Jan 3, 2019

A newsroom user reported the following:

Can we make the default publish date “immediately” like it was before the site update? Still having some issues with accidentally backdating, taking too long to change the date/time when publishing breaking news, etc.

After investigation, I described the issue as seen above: The post date should not be set when post is "pending review". The newsroom user agreed with this assessment.

Publishing a post from draft is immediately but the other statuses we use regularly (pending, proofed, reserve) the post date gets set

Here is a GIF demonstrating this behavior, which I believe constitutes a "bug" since the behavior is different than what happened in the same situation pre-Gutenberg.

2019-01-03 10-42-42 2019-01-03 10_43_21

This issue seems related to #7195 and solution #9967. cc @kadamwhite @earnjam @tofumatt who participated on the original thread.

@earnjam
Copy link
Contributor

earnjam commented Jan 3, 2019

Ah, that's because it's only looking at status of draft or auto-draft. We'll need to account for pending also.

@earnjam
Copy link
Contributor

earnjam commented Jan 3, 2019

Thinking about this a bit more, this does highlight that we can't fully support floating dates and custom post statuses with the hackish solution we're using of comparing the two date values + post status.

Just adding pending like I've done in #13178 won't fix the issue for proofed and reserve mentioned in the original issue. Technically custom post statuses aren't officially supported by core, but they are still used pretty broadly.

We should go ahead and fix for pending since it's a core status, but I think we'll need to circle back to the discussion of adding some type of date_floating flag to fix this more broadly, or else break back compatibility by reverting to returning the actual stored database value for date_gmt instead of calculating it from date.

See: https://core.trac.wordpress.org/ticket/39953 for additional discussions and history on this one.

nylen pushed a commit to nylen/wordpress-develop-svn that referenced this issue Sep 23, 2019
See: WordPress/gutenberg#13176

Props TimothyBlynJacobs.
Fixes #39953.


git-svn-id: https://develop.svn.wordpress.org/trunk@46274 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this issue Sep 23, 2019
See: WordPress/gutenberg#13176

Props TimothyBlynJacobs.
Fixes #39953.


git-svn-id: https://develop.svn.wordpress.org/trunk@46274 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this issue Sep 23, 2019
See: WordPress/gutenberg#13176

Props TimothyBlynJacobs.
Fixes #39953.

Built from https://develop.svn.wordpress.org/trunk@46274


git-svn-id: http://core.svn.wordpress.org/trunk@46086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this issue Sep 23, 2019
See: WordPress/gutenberg#13176

Props TimothyBlynJacobs.
Fixes #39953.

Built from https://develop.svn.wordpress.org/trunk@46274


git-svn-id: https://core.svn.wordpress.org/trunk@46086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
miya0001 pushed a commit to cjk4wp/wordpress that referenced this issue Oct 26, 2019
See: WordPress/gutenberg#13176

Props TimothyBlynJacobs.
Fixes #39953.


git-svn-id: http://develop.svn.wordpress.org/trunk@46274 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Saving Related to saving functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants