Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid trailing space at the end of a translatable string #15813

Closed
ocean90 opened this issue May 24, 2019 · 1 comment · Fixed by #17842
Closed

Avoid trailing space at the end of a translatable string #15813

ocean90 opened this issue May 24, 2019 · 1 comment · Fixed by #17842
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Edit Post /packages/edit-post

Comments

@ocean90
Copy link
Member

ocean90 commented May 24, 2019

Original report: https://core.trac.wordpress.org/ticket/47374

Source:

gutenberg/packages/edit-post/src/components/sidebar/post-link/index.js

Lines 89 to 94 in 636b7bf

<p>
{ __( 'The last part of the URL. ' ) }
<ExternalLink href="https://codex.wordpress.org/Posts_Add_New_Screen">
{ __( 'Read about permalinks' ) }
</ExternalLink>
</p>

We should make sure that it's always there instead of relying on translators to not miss the trailing space in the string.
@ocean90 ocean90 added Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Edit Post /packages/edit-post labels May 24, 2019
@swissspidy
Copy link
Member

We could simply add { ' ' } in there.

Of course ideally these wouldn't be separate strings (see #9846) at all.

@desaiuditd desaiuditd mentioned this issue Oct 8, 2019
Merged
5 tasks
gziolo pushed a commit that referenced this issue Oct 10, 2019
@desaiuditd @gziolo
Fixes #15813 (#17842)
4634c4f
gziolo pushed a commit that referenced this issue Oct 15, 2019
@desaiuditd @gziolo
Fixes #15813 (#17842)
c69a4f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Edit Post /packages/edit-post
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid trailing space at the end of a translatable string.
2 participants
@ocean90 @swissspidy