Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment looks off in the pre-publish panel #18249

Closed
mtias opened this issue Nov 2, 2019 · 7 comments
Closed

Alignment looks off in the pre-publish panel #18249

mtias opened this issue Nov 2, 2019 · 7 comments
Labels
Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Nov 2, 2019

image

@mtias mtias added the [Type] Bug An existing feature does not function as intended label Nov 2, 2019
@jorgefilipecosta jorgefilipecosta added the Needs Design Feedback Needs general design feedback. label Feb 8, 2020
@paaljoachim
Copy link
Contributor

I just tested locally using Desktop Server, Chrome and Gutenberg version 7.5
This is what I see:
Screen Shot 2020-02-18 at 18 44 24

Screen Shot 2020-02-18 at 18 44 31

I am thinking this issue has been fixed in one of the Guteneberg versions after the initial issue was created.

@folletto
Copy link
Contributor

I'd note it still feels oddly placed even when it's centered, as the × makes it still looks off.

I wonder if we should explore a bit more how the pre- and post-publish panels work and are aligned.

Maybe something like replacing the × in both pre/post with two buttons that take the full top area:

| [ Cancel ] [ Publish ]| vs | [ Publish ] × |

@mapk
Copy link
Contributor

mapk commented Feb 18, 2020

A few of us in today's Design triage in slack tested this out again. We remembered that this was recently solved with this PR: #17726

After testing again, I did not notice any alignment issues.

Screen Shot 2020-02-18 at 9 45 18 AM

There was some desire to iterate more on the placement which can be done as mentioned by @folletto above. I remember another issue/PR exploring the positioning further as well #19175.

@mtias
Copy link
Member Author

mtias commented Feb 18, 2020

I'll close.

@mtias mtias closed this as completed Feb 18, 2020
@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 18, 2020

Here is an issue in regards to what Erin @folletto mentioned above.

I wonder if we should explore a bit more how the pre- and post-publish panels work and are aligned.

Maybe something like replacing the × in both pre/post with two buttons that take the full top area:

| [ Cancel ] [ Publish ]| vs | [ Publish ] × |

#19175

@paaljoachim
Copy link
Contributor

Followup:

Here is from a Norwegian site. (Yesterday I only checked a local English language site.)

Screen Shot 2020-02-19 at 05 30 49

Screen Shot 2020-02-19 at 05 31 11

Bottom line: The problem remains. There is actually a bigger fix that is needed. Which perhaps can be done in #19175

@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 13, 2020

The problems remains but now it shows a little different.
Screen Shot 2020-03-13 at 10 27 13

Here is an example when I published the Core Editor summary.
Screen Shot 2020-03-13 at 10 39 27

Screen Shot 2020-03-13 at 10 39 57

We might as well reopen this issue.
@mtias @mapk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants