Fix off center post-publish button

[richtabor]

Description

Fixes #17691, by centering the Post Publish button and applying a bit of padding to keep the close button off the edge of the panel header.

How has this been tested?

Tested in supported browsers.

Screenshots

Types of changes

Bug fix

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[enriquesanchez]

Left some comments on packages/edit-post/src/components/layout/style.scss

[mapk]

I've removed the spacer, adjusted the height of the button and centered it. While it's not perfect, it should work nicely with translations. Check it.

[enriquesanchez]

Just tested this and looks 👍

[mapk]

I think we're good on this now. Thanks for testing @enriquesanchez!

[richtabor]

Yup, looks great!

[mapk]

@richtabor I'm not sure why we're having failed tests. Can you try rebasing?

[richtabor]

@richtabor I'm not sure why we're having failed tests. Can you try rebasing?

I did, though it's still failing - I'm not entirely sure why?

[mmtr]

@richtabor I'm not sure why we're having failed tests. Can you try rebasing?

I did, though it's still failing - I'm not entirely sure why?

They seem to be unrelated to changes on this PR.

Failing E2E:

 Embedding content › should switch to the WordPress block correctly
    expect(jest.fn()).not.toHaveWarned(expected)
    Expected mock function not to be called but it was called wit

Mobile unit tests:

Cannot find module 'Platform' from 'react-native-implementation.js'
    However, Jest was able to find:
    	'./platform.android.js'
    	'./platform.ios.js'
    	'./platform.js'

I see this PR was merged recently with the same errors: #18247 So, maybe builds are not currently stable? cc @gziolo

You can also try rebasing instead of merging, although I don't think that'd have any effect.

[aduth]

I think there's some intermittent failures in the E2E test with the "SameSite" cookie warning. The mobile tests are allowed to fail, so they shouldn't be considered as a blocker.

I restarted the build to try to clear up the failure.

[richtabor]

Here's a gif with the latest commit, with a slight tweak to make the Publish button centered across the entire panel header:

[mapk]

Looks great, @richtabor! Let's get this merged!