Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant "Link to" in Social Icons aria-label #20665

Closed
mrwweb opened this issue Mar 5, 2020 · 3 comments · Fixed by #21369
Closed

Remove Redundant "Link to" in Social Icons aria-label #20665

mrwweb opened this issue Mar 5, 2020 · 3 comments · Fixed by #21369
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts Needs Accessibility Feedback Need input from accessibility

Comments

@mrwweb
Copy link

mrwweb commented Mar 5, 2020

At present, a social link looks like this:

<a href="https://profiles.wordpress.org/" aria-label="Link to WordPress">
  <svg width="24" height="24" viewBox="0 0 24 24" version="1.1" xmlns="http://www.w3.org/2000/svg" aria-hidden="true" focusable="false">
    <path d="..."></path>
  </svg>
</a>

I believe "Link to" in the default aria-label can be removed. Because it's a link element, that is redundant information.

@Soean
Copy link
Member

Soean commented Mar 5, 2020

It was added in #18651, see the issue #18620 why it was added.

@mrwweb
Copy link
Author

mrwweb commented Mar 5, 2020

To clarify: Having an aria-label is good. What I'm saying is that the specific words "Link to" in "Link to Twitter" or "Link to Facebook" in the default text are redundant.

A screen reader will say something like "{aria label}. Link.", so in this case it would say "Link to Facebook. Link." Therefore, the aria-label should just say "Twitter" or "Facebook".

Is that clearer?

@Soean Soean added the Needs Accessibility Feedback Need input from accessibility label Mar 5, 2020
@aduth aduth added the [Block] Social Affects the Social Block - used to display Social Media accounts label Mar 6, 2020
@0aveRyan
Copy link
Contributor

0aveRyan commented Apr 3, 2020

@mrwweb I've validated and opened a PR to address this, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts Needs Accessibility Feedback Need input from accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants