Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overly verbose aria-label in Social Link block #21369

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fix overly verbose aria-label in Social Link block #21369

merged 2 commits into from
Apr 3, 2020

Conversation

0aveRyan
Copy link
Contributor

@0aveRyan 0aveRyan commented Apr 3, 2020

Description

Fixes #20665.

This simplifies the a11y-compatibility added to the Social Link block, removes a confusing translatable string and provides an improved experience for screen reader users.

Screen readers announce anchors as links, so having "Link to" was redundant.

How has this been tested?

  • I've navigated a document containing Social Link blocks using VoiceOver on macOS (see screenshots below).

Screenshots

Before:
Example of a11y bug in Social Link block. Screenshot of rendered icons with VoiceOver saying 'Link, Link to Instagram'

After:
Patch in this PR for Social Link block. Screenshot of rendered icons with VoiceOver saying 'Link, Instagram'

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@0aveRyan 0aveRyan requested a review from mkaz as a code owner April 3, 2020 01:18
@0aveRyan 0aveRyan requested a review from aduth April 3, 2020 01:18
@aduth aduth added [Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Apr 3, 2020
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thank you.

@aduth aduth merged commit 63a2e77 into WordPress:master Apr 3, 2020
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Apr 3, 2020
@0aveRyan 0aveRyan deleted the fix/duplicative-social-link-aria branch April 3, 2020 17:54
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Redundant "Link to" in Social Icons aria-label
2 participants