Link modal suggestions only include posts when they should also include pages and CPTs

[afercia]

The link modal links suggestions implemented in #1985 currently searches just for posts.

Instead, the current implementation in WordPress searches also for pages and Custom Post Types (any public post):

As mentioned in #1985, this is a limitation of the REST API. See the related Trac ticket: https://core.trac.wordpress.org/ticket/39965. Regardless of the reason why, right now there's no feature parity with the current WordPress implementation.

There are also performance concerns, since by default the REST API returns all the post fields including the post content. The response can be huge in size, even several hundreds KB or more than 1MB with very long posts. See related considerations on:
https://core.trac.wordpress.org/ticket/38920
https://core.trac.wordpress.org/ticket/38922
and especially:
"REST API: Provide interface to include or exclude specific fields from response JSON"
https://core.trac.wordpress.org/ticket/38131

[westonruter]

There are also performance concerns, since by default the REST API returns all the post fields including the post content. The response can be huge in size, even several hundreds KB or more than 1MB with very long posts.

For this, do note that you can make the request with ?context=embed and the content field will be excluded. That would be a good short term fix.

[afercia]

I'd suggest to milestone https://core.trac.wordpress.org/ticket/39965 (add search endpoint) for 5.0.

[jeffpaul]

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

[braders]

In the current editor it is also possible to inject non-WordPress resources with the wp_link_query filter (For example allow selection of archive pages). It would be great if this functionality (or similar) was supported by the new editor.

[danielbachhuber]

@felixarntz is going to do a first pass on this against Gutenberg over the next week.