Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonBlockAppender component in /block-editor is exported with incorrect name #25885

Closed
daledesilva opened this issue Oct 7, 2020 · 4 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@daledesilva
Copy link

Describe the bug
Inside the components index file in block-editor, The ButtonBlockAppender is exported as ButtonBlockerAppender

This file:
https://github.com/WordPress/gutenberg/blob/master/packages/block-editor/src/components/index.js

ie. line 25 is:
export { default as ButtonBlockerAppender } from './button-block-appender';
but should be:
export { default as ButtonBlockAppender } from './button-block-appender';

Expected behavior
It should be exported as it's expected name.

Editor version:

  • WordPress version: 5.5.1
  • Default block editor
@daledesilva
Copy link
Author

Related issue that could cause confusion:
#25886

@talldan talldan added [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended Backwards Compatibility Issues or PRs that impact backwards compatability Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Oct 22, 2020
@talldan
Copy link
Contributor

talldan commented Oct 22, 2020

Oh dear! I think it's been like this for a while, too. 😄

Should be an easy fix and would be happy to see a contribution that fixes it.

We may have to leave the incorrect export in the codebase to ensure backwards compatibility.

@gaavar
Copy link
Contributor

gaavar commented Dec 14, 2020

@talldan I created a pull request to fix this. I also noticed that the pull request requires some form of testing. I need some guidance on how to test this change.

@Mamaduka
Copy link
Member

Fixed via #32580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants