Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render widgets in the editor with the same style as in the theme #26163

Closed
draganescu opened this issue Oct 15, 2020 · 5 comments · Fixed by #32683
Closed

Render widgets in the editor with the same style as in the theme #26163

draganescu opened this issue Oct 15, 2020 · 5 comments · Fixed by #32683
Assignees
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

Enhancement
While the classic widgets editor did not have any preview functionality, the current preview really doesn't match the front end for blocks used as widgets.

Is there any way to bring over the styles used for the sidebars (widget areas) in themes?

To reproduce
0. Make sure to have the Gutenberg plugin active and the 2020 theme

  1. Go to Appearance > WIdgets
  2. Add a quote and customize it to have a green background, save.
  3. Go to front end
  4. See the style of the Quote

Expected behavior
I would love to see the same styles that the theme applies to the widget when rendered.

Screenshots
Screenshot 2020-10-15 at 17 40 05

Screenshot 2020-10-15 at 17 40 12

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Oct 15, 2020
@talldan talldan added the Needs Technical Feedback Needs testing from a developer perspective. label Jan 6, 2021
@draganescu draganescu changed the title Render in the editor with the same style as in the theme Render widgets in the editor with the same style as in the theme Feb 18, 2021
@noisysocks
Copy link
Member

I am wondering if we should implement this enhancement for v1 of the widgets editor?

@noisysocks noisysocks removed the Needs Technical Feedback Needs testing from a developer perspective. label Apr 8, 2021
@draganescu
Copy link
Contributor Author

draganescu commented Apr 9, 2021

Well, for one I am thinking of how the same thing in the customizer looks, once in the sidebar once in the preview.
It does not look like a critical issue but it is a great enhancement.

Also, overall, we should aim to solve this problem wherever we use block editors. It is a great opportunity to bump into limitations of Gutenberg and fix them. The block editors try very hard to be as close as possible an approximation of the front end and are only getting better at it.

@noisysocks
Copy link
Member

If we can do it easily then I'm very keen. It would be a really nice UX. I don't think this enhancement is necessarily a priority for WordPress 5.8, though.

@noisysocks noisysocks added the Needs Design Needs design efforts. label Jun 8, 2021
@noisysocks
Copy link
Member

See also discussion in #32449 (comment).

@noisysocks
Copy link
Member

Closing in favour of https://core.trac.wordpress.org/ticket/53344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
4 participants