-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing a block's style doesn't do anything when "Use theme styles" is turned off #32449
Comments
This needs to be fixed in Core, so I've opened a ticket on Trac. Do we really want theme styles in the Widgets editor though? I was under the impression, from the report in #31947, that that might not be the case. E.g. if we do add those theme styles in, the editor will look like this with Twenty Twenty One: |
What is the downside of loading them? In my testing I found this to be a nice feature. |
I think this behavior does actually match the post editor when the "theme styles" option is turned off in the Preferences modal under Appearance → Use theme styles / Make the editor look like your theme. One thing to note is that the screenshot @tellthemachines shared above is not how I would expect this preference to work, with the theme color being applied to the frame of the page but not to the widget areas themselves (which could help you avoid things like changing the text color to something clashing/illegible, for example). So it may need more design exploration if we go in this direction. Also FWIW, introducing this preference into the Customizer editor would definitely need a more significant design explore (but may be less useful there for similar reasons as those mentioned in #31139). |
@critterverse we could remove the background color from the widget areas, but then we'll need some kind of outline so they're easy to tell apart: I agree being able to preview the theme styles is nice, but perhaps it can be an enhancement for later. |
Thanks for looking into this @tellthemachines! Looks like there's two issues at play here:
|
Changing a block's style with theme styles turned off still works on the front end; the only thing that doesn't work is the editor preview of the style change. Fixing this - if by fixing we mean loading only the block-related styles and not general editor styles such as background color - would mean separating out the block styles from the general styles, which I think could only be done by themes themselves. Not sure if the changes coming with global styles will make this easier, but in any case we also have the issue of determining what's a block style and what isn't: say for instance font-related styles that apply to more than one block. Independently of the technical solution, it doesn't feel at all clear cut: which theme style changes should we allow to be previewable when the user explicitly disables theme styles in the editor? |
Description
Changing a block's block style doesn't seem to do anything when "Use theme styles" is turned off.
Step-by-step reproduction instructions
Expected behaviour
The appearance of the block should change.
Actual behaviour
Nothing happens.
Screenshots or screen recording
This recording is of the widgets editor, but it's the same.
Kapture.2021-06-04.at.15.37.35.mp4
The text was updated successfully, but these errors were encountered: