Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy widget should not be "previewable" in the customizer #31139

Closed
draganescu opened this issue Apr 23, 2021 · 3 comments
Closed

Legacy widget should not be "previewable" in the customizer #31139

draganescu opened this issue Apr 23, 2021 · 3 comments
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

It makes no sense to preview a legacy widget when using the LegacyWidget block in the Customizer since there is a better and full page preview on the screen.

legacy-preview-customzier

In the screenshot above the previews don't even match (and they probably won't no matter what we do).

Can we remove the preview based on the editor that uses the LegacyWidget block?

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. labels Apr 23, 2021
@noisysocks
Copy link
Member

@critterverse: What do you think?

@critterverse
Copy link
Contributor

critterverse commented May 17, 2021

It would be kind of a shame to lose to the preview for legacy widgets that have one, if only because they feel more Gutenberg-like than the legacy widgets without a preview. Checked a few different themes and it looks like the previews already match pretty closely in most instances — the thing that seems the most inconsistent between the sidebar and preview area is the styling for titles. Would it be possible to make the title match more closely?

(Twenty Twenty-One also adds bullet points into the sidebar preview in a lot of cases but that seems to only happen with that theme...)

If not, maybe we should consider defaulting to the behavior for legacy widgets with no preview.

@draganescu
Copy link
Contributor Author

Yea, considering some widgets have immense setup forms and tiny previews, ditching the preview would make the sidebar unusable. I will close this idea, that while it makes "sense" it would make things more rational but much harder to use.

My proposal, let's not change anything. \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants