Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Block: Change the button to a Button Block #27760

Closed
scruffian opened this issue Dec 16, 2020 · 4 comments
Closed

File Block: Change the button to a Button Block #27760

scruffian opened this issue Dec 16, 2020 · 4 comments
Labels
[Block] File Affects the File Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@scruffian
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The File Block has its own implementation of a button.

Describe the solution you'd like
The File Block should use the button Block so that the button can have the same controls as other buttons.

@rodrigo-arias
Copy link

This would be a nice improvement, currently if you select the option "Open in a new tab" for the text link, you have no way to select the same for the download button.

CleanShot 2021-07-27 at 19 38 40

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Feb 2, 2022

Had a quick look at this, but because it will require converting the block to use innerBlocks, it will currently suffer from the same issue as noted here in the Quote block conversion to innerBlocks PR, so probably best to leave until @dmsnell works through that.

@scruffian
Copy link
Contributor Author

I think the best way forward here is to use an "element button": #40260

@scruffian
Copy link
Contributor Author

This was closed by #40260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

No branches or pull requests

3 participants