Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twenty Twenty-One Blocks: Migrate over default block styles as theme.json settings. #82

Open
20 of 53 tasks
kjellr opened this issue Nov 12, 2020 · 0 comments
Open
20 of 53 tasks

Twenty Twenty-One Blocks: Migrate over default block styles as theme.json settings. #82

kjellr opened this issue Nov 12, 2020 · 0 comments

Comments

@kjellr
Copy link
Collaborator

kjellr commented Nov 12, 2020 •
edited
Loading

Many (most) blocks in Twenty Twenty-One have custom styles applied. We should work towards making the block-based version mimic those styles.

It's ok to migrate over a little CSS for transitions and other extraneous CSS, but basic styles like font specifications should be defined as theme.json settings whenever possible.

This is the full list of blocks that have stylesheets in Twenty Twenty-One. They'll need to be individually audited to see which how much can be migrated over today. Some may already be complete (headings and separator styles for example), so we can check those off after we double check.

For styles which should be possible via Gutenberg's design tools (e.g. color, spacing, etc), please open an issue in the Gutenberg repo.

These Gutenberg issues need to be solved before we can achieve this:
@kjellr kjellr mentioned this issue Nov 17, 2020
Merged
This was referenced Nov 24, 2020
Closed
Open
@scruffian scruffian mentioned this issue Nov 25, 2020
Closed
@mendezcode mendezcode mentioned this issue Nov 26, 2020
Closed
@MaggieCabrera MaggieCabrera mentioned this issue Nov 27, 2020
Open
@mendezcode mendezcode mentioned this issue Nov 27, 2020
Closed
@scruffian scruffian mentioned this issue Nov 27, 2020
Closed
This was referenced Nov 27, 2020
Open
Closed
Closed
Closed
This was referenced Dec 4, 2020
Closed
Open
@carolinan carolinan mentioned this issue Dec 7, 2020
Open
This was referenced Dec 9, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
This was referenced Dec 9, 2020
Open
Closed
Open
Open
@MaggieCabrera MaggieCabrera mentioned this issue Dec 10, 2020
Closed
jacklenox pushed a commit that referenced this issue Dec 11, 2020
TT1 Blocks: Migrate columns styles
77c71af 
Adds the column styles needed for TT1 as part of #82

Closes #115
@jacklenox jacklenox mentioned this issue Dec 11, 2020
Closed
@danieldudzic danieldudzic mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjellr