Twenty Twenty One Blocks: Migrate Audio Block styles #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
requested review from
aristath,
carolinan,
jffng,
kjellr and
scruffian
scruffian
reviewed
Dec 3, 2020
|
|
||
| .wp-block-audio audio:focus { | ||
| outline-offset: 5px; | ||
| outline: 2px solid var(--wp--preset--color--dark-gray); |
There was a problem hiding this comment.
Do you think this should be a more general outline style for all elements?
There was a problem hiding this comment.
Yeah, I think it should probably be part of the global theme focus styles. I feel like it can probably be left out until a solution for WordPress/gutenberg#27075 is implemented.
There was a problem hiding this comment.
yeah, that makes sense. I'm closing this PR then. Thank you!
|
I added the GB PR link to #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds styles for the outline on focus for the Audio block
The PR on GB has been closed (WordPress/gutenberg#27335), decided this should be resolved within the theme.
Broken out of #82
Closes #101