Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT1 Blocks: Spacer Block: Migrate CSS to theme.json #130

Closed
scruffian opened this issue Dec 9, 2020 · 2 comments
Closed

TT1 Blocks: Spacer Block: Migrate CSS to theme.json #130

scruffian opened this issue Dec 9, 2020 · 2 comments

Comments

@scruffian
Copy link
Collaborator

The code is here.

From #82
@scruffian scruffian mentioned this issue Dec 9, 2020
Open
53 tasks
@pbking
Copy link
Collaborator

pbking commented Dec 14, 2020

According to comments here I believe that the "mobile media query" style that TT1 blocks implemented will not be replicated for TT1-blocks.

The rest of the styles appear to already be reflected appropriately according to this demonstration.

I believe that this can simply be closed as the spacer works as expected without modification to either the theme or Gutenberg.

@kjellr
Copy link
Collaborator

kjellr commented Dec 15, 2020

Agreed, this one is all set. 👍

@kjellr kjellr closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pbking @scruffian @kjellr