Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextual block toolbar: Move below the block when bumping against the top edge #29464

Closed
jasmussen opened this issue Mar 2, 2021 · 4 comments · Fixed by #33981
Closed

Contextual block toolbar: Move below the block when bumping against the top edge #29464

jasmussen opened this issue Mar 2, 2021 · 4 comments · Fixed by #33981
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Package] Interface /packages/interface

Comments

@jasmussen
Copy link
Contributor

What problem does this address?

Mostly in the site editor, if you select a block close to the top of the screen, it bumps against the screen edge and gets pushed downwards, covering content:

Screenshot 2021-03-02 at 09 04 09

What is your proposed solution?

In those cases, show the block toolbar below the block:

Screenshot 2021-03-02 at 09 04 57

We might need an additional heuristic, that still shows the toolbar above the block if the block is taller than, say, 300px.

@jasmussen jasmussen added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Full Site Editing [Package] Interface /packages/interface labels Mar 2, 2021
@jasmussen jasmussen changed the title Contextual block toolbar: Move below the block when bumping against the top edte Contextual block toolbar: Move below the block when bumping against the top edge Mar 2, 2021
@annezazu
Copy link
Contributor

annezazu commented May 7, 2021

Noting here that this same problem occurs in template editing mode (not sure how much code is shared between the site editor and template editing mode). Edited to add a quick video:

navigation.block.squished.mov

@ellatrix
Copy link
Member

I think the same dark padding as the template editor would be a nice solution.

@kjellr
Copy link
Contributor

kjellr commented May 26, 2021

Noting that this will be a frequent issue for header template parts, since they'll often be the first block included on the page. Currently, the block toolbar completely hides the arrows in the patterns carousel for that block's placeholder:

119679526-6e0b8380-be0e-11eb-94e8-9a46a5e9b95a

@jasmussen
Copy link
Contributor Author

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Package] Interface /packages/interface
Projects
None yet
5 participants