Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: block toolbar covers blocks that are close to top of header template #31008

Closed
Sandstromer opened this issue Apr 20, 2021 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@Sandstromer
Copy link

Description

In the site editor, when editing the header, any blocks that are close to the top of the template are obscured by the toolbar.
This is very apparent when removing the spacer block in the header of TT1-Blocks theme.
When the toolbar obscures the block it is almost impossible to edit that particular block.
Not all themes will contain a 70px spacer as the first block in the header, so making editing such things as site-title/tagline/navigation almost impossible.

Step-by-step reproduction instructions

  1. With TT1-Blocks theme, go to Site Editor
  2. Select the header template part
  3. Remove the 70px spacer block at the top of the header
  4. Notice how you cannot edit the blocks that are now appearing at the top of the header, because they become obscured by the toolbar when selecting the block

Expected behaviour

All blocks should be editable and not obscured.

Actual behaviour

Blocks close to the top of the header are obscured and uneditable.

Screenshots or screen recording (optional)

gutenberg-header-editing-01
gutenberg-header-editing-02
gutenberg-header-editing-03

Code snippet (optional)

WordPress information

  • WordPress version: 5.7.1
  • Gutenberg version: 10.4.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? TT1-Blocks

Device information

  • Device:
  • Operating system:
  • Browser:
@skorasaurus
Copy link
Member

similar problem at #26239

@skorasaurus skorasaurus added the [Type] Bug An existing feature does not function as intended label Apr 30, 2021
@ellatrix
Copy link
Member

I wonder if some gray padding like the template editor would be beneficial here. It would also ensure there's always some clickable area to clear selection. Cc @jasmussen

@jasmussen
Copy link
Contributor

Is this a duplicate of #29464? In that I also suggest that instead of adding padding, we can move the toolbar below the block. That lets us reserve the padding for indicating template editing, and it also takes up less space.

@ellatrix
Copy link
Member

Yes, this is a duplicate of #31008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants