Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test coverage for REST API menus endpoints. #34992

Closed
spacedmonkey opened this issue Sep 21, 2021 · 1 comment · Fixed by #36177
Closed

Improve unit test coverage for REST API menus endpoints. #34992

spacedmonkey opened this issue Sep 21, 2021 · 1 comment · Fixed by #36177
Assignees
Labels
[Status] In Progress Tracking issues with work in progress

Comments

@spacedmonkey
Copy link
Member

What problem does this address?

Background

The menus endpoints, menu, menu locations and menu items were originally worked on by @spacedmonkey and developed in another github repo. These endpoints, were merged into this plugin in #20292.

Now that the menus endpoints are being used for the menu screen. There have been a number of changes to the REST API endpoint over the last couple of months these changes include.

#31656, #34673, #34888, #34835

Let's audit and improve PHPUnit test coverage for these endpoints.

What is your proposed solution?

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Sep 21, 2021

Let's consider adding these unit tests as well: 5b6c2d2
Discussion can be found here: #34857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants