Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menus endpoints. #20292

Merged
merged 5 commits into from
Mar 18, 2020
Merged

Conversation

spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Feb 18, 2020

Description

Add menu endpoints from https://github.com/WP-API/menus-endpoints

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@spacedmonkey
Copy link
Member Author

CC // @marekhrabe @draganescu

@draganescu
Copy link
Contributor

@spacedmonkey this is awesome news for the Navigation block :)

Is there a Trac ticket we could tie this PR to?

@spacedmonkey
Copy link
Member Author

@draganescu The original ticket is https://core.trac.wordpress.org/ticket/40878
However, I have been working on the feature plugin, so for history, it is best to look there.

This PR has a lot of code in, but barring some very small tweaks ( to change the name from wp/v2 to __experimental), it is a copy and paste from https://github.com/WP-API/menus-endpoints which as already been code reviewed by @TimothyBJacobs and @kadamwhite . This PR should quick to get merged.

@draganescu
Copy link
Contributor

My bad @spacedmonkey :) I didn't pay attention to which repo this is and I thought it was a patch for core (a PR against the wordpress-develop master) 😁

@paaljoachim
Copy link
Contributor

I do believe that
@getdave @retrofox
might want to know about this PR.

Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have worked with this PR in #18869 and have had no issues. Also considering:

  • all endpoints are 'hidden' behind __experiemental,
  • the code comes straight from the feature plugin where it has been reviewed extensively by the REST API team

we can merge this and use it for the issues that need it.

@draganescu draganescu merged commit 56ec52e into WordPress:master Mar 18, 2020
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 18, 2020
@getdave
Copy link
Contributor

getdave commented Mar 20, 2020

I'm really pleased to see this got merged 🎉 🎉 🎉 Great work everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants