Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transforming quote with citation to paragraph should create two paragraphs #3559

Closed
jasmussen opened this issue Nov 20, 2017 · 7 comments
Closed
Assignees
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

If you have a quote with a citation, and transform this to paragraph, you get a paragraph of the quote, and an empty blockquote with just the citation:

quote transformation

Would it be nicer if this transformed into two paragraphs instead?

The inverse should not be true though — selecting two paragraphs and transforming into a quote should have a quote with two paragraphs and no citation.

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Nov 20, 2017
@youknowriad
Copy link
Contributor

What about a quote with multiple paragraph and a citation? Should it be three paragraphs or a paragraph and a quote? I suppose three paragraphs for consistency with the proposed behavior here.

@jasmussen
Copy link
Contributor Author

What about a quote with multiple paragraph and a citation?

I lump it in with transforming to and from a list. 5 paragraphs turn to 5 list items in one direction, and back to 5 paragraphs the other direction.

For the quote, 3 paragraphs turn to a blockquote with 3 paragraphs. If you add a citation and transform back, I think it makes more sense to get 4 paragraphs than 3 paragraphs and an empty quote with a citation.

Is it technically really tricky?

@youknowriad
Copy link
Contributor

youknowriad commented Nov 20, 2017

Is it technically really tricky?

No it's not (not until we use nested blocks :P)

@jasmussen
Copy link
Contributor Author

No it's not (not until we use nested blocks :P)

;) No nesting!

@jorgefilipecosta
Copy link
Member

Thank you for your report @jasmussen this should be fixed with the merge of #3802.

@jasmussen
Copy link
Contributor Author

Hooray! Thank you.

@HJMeyer
Copy link

HJMeyer commented Jan 3, 2019

Sorry, but exactly this behaviour was the first stumbling stone I experienced when I tested Gutenberg for the first time today. I tried to transform the quote + citation of Matt Mullenweg, 2017 to a paragraph, and then to transform it back. First step: I click on icon ‘paragraph’: the quote and the citation become to two separate paragraphs. Then I click on the icon for ‘quote’: I get two quotes, each with empty citation field.
This is not what I expected when I read: “the structure of the quote is protected even if you select, modify, or remove the source. It’s always easy to add it back.“ This promise is not met, because the structure is gone. This is not intuitive. If it is possible to make two blocks from one, it must be possible to merge to blocks to one.
It would be easy if you added an icon for transforming a paragraph to a citation (working only if the previous block is a quote).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants