Switching Quote block with HTML tags in it splits it in two

[hedgefield]

Steps to Reproduce

1. Create a new post, type some text in a Text block
2. Select part of the text and turn it into a link
3. Turn the block into a quote
4. Turn the block back into text, and it splits in two

Version 0.3.0

Expected Behavior

For the text to stay together in one block.

Current Behavior

The text gets split into two blocks.

[westonruter]

There seems to be some issues with the block transformation:

gutenberg/blocks/library/quote/index.js

Lines 62 to 84 in 313e6c3

	transform: ( { value, citation, ...attrs } ) => {
	const textElement = value[ 0 ];
	if ( ! textElement ) {
	return createBlock( 'core/text', {
	content: citation,
	} );
	}
	const textContent = isString( textElement ) ? textElement : textElement.props.children;
	if ( Array.isArray( value ) || citation ) {
	const text = createBlock( 'core/text', {
	content: textContent,
	} );
	const quote = createBlock( 'core/quote', {
	...attrs,
	citation,
	value: Array.isArray( value ) ? value.slice( 1 ) : '',
	} );
	return [ text, quote ];
	}
	return createBlock( 'core/text', {
	content: textContent,
	} );

I'm taking a look.

[westonruter]

I think the issue may have been introduced by #1078, where a Text block now only contains a single paragraph. /cc @iseulde

[westonruter]

See one possible improvement in #1774.

[karmatosed]

I am still seeing this in 1.0.

[BoardJames]

I just tried to replicate this and I am not seeing the link split off as in the video. It is still creating 2 blocks though which is probably not what we want when the quote attribution field is empty.

[jasmussen]

I can't reproduce the "breaking on the link" issue, but it still does create two blocks, and I think #3559 is related or the same.

[jorgefilipecosta]

Thank you for your report @hedgefield this should be fixed with the merge of #3802.