Chrome: Adding the Permalink popup #1042
Conversation
youknowriad
added
the
General Interface
|
Editing permalinks is not always authorised, a permalink format containing the "slug" is required to allow editing the slug. AFAIK It's not possible to fetch the permalink format using the Rest API right now. Thoughts on this @nylen |
|
NICE! Thanks for working on this. Let's make a few visual improvements. I can help with this, and it can be in a separate PR. For example, let's pretend the title field is a block. So it gets the same 2px gray block boundary as a selected block is. That lets us also position the permalink popup in the exact same coordinates as the block toolbars are. That is, indended from the left edge of the selected border the block padding distance, and 2px pushed down from the top border so it's "sitting on the border":
Can we change the text of the copy button to say "Copied!" when you click? Can we make the permalink clickable, in addition to being editable? |
|
@jasmussen Thanks for the review, I've tried to address the feedback as I could. |
|
Love this! Really impressive work. Teensy nitpick — can we add the same fade animation to the title border as the normal blocks have? Otherwise, visually SOLID. Thank! 👍 |
youknowriad
force-pushed
the
add/readonly-permalink
branch
from
0c6da2f
to
6434533
Compare
|
When I focus the title, then focus a block, and then again the title, some UI lingers.
|
| return ( | ||
| <Button | ||
| ref={ ref => this.button = ref } | ||
| className={ classes } |
There was a problem hiding this comment.
It's a bit confusing that that there's no click handler here.
There was a problem hiding this comment.
yep, that's how the clipboard library works.
editor/post-title/index.js
Outdated
| document.activeElement === textarea && | ||
| textarea.selectionStart !== textarea.selectionEnd | ||
| ) { | ||
| this.select(); |
There was a problem hiding this comment.
Might it be better to name this onSelect?
| } | ||
|
|
||
| handleClickOutside() { | ||
| this.setState( { isSelected: false } ); |
There was a problem hiding this comment.
It doesn't because of the popup
|
Created core ticket ( + patch ) for REST API |
|
Did this regress? I don't see it in master anymore... |
|
@jasmussen Did you save your post? |
|
Ah of course, that's it. |
| } | ||
|
|
||
| onSelectionChange() { | ||
| const textarea = this.textareaContainer.textarea; |
There was a problem hiding this comment.
What is this doing? Can we add an inline comment?
refs #577
ClipboardButtonbased on theclipboardpackage