Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Privacy Policy help notice #11999

Merged
merged 4 commits into from
Nov 19, 2018

Commits on Nov 16, 2018

  1. Display the privacy policy help notice with the admin_notices actio…

    …n hook.
    
    The new editor does not support the `edit_form_after_title` action hook. Because WordPress Core uses this hook to output the notice, it is not printed to the screen.
    
    After WordPress#11604 is merged, legacy style admin notices (`<div class="notice">...notice content...</div>`) will be consumed by the Notices API and displayed. This change ensures that when WordPress#11604 is merged the privacy policy notice will appear again when editing the privacy policy page.
    desrosj committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    d1fd713 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fea8a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e05911a View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2018

  1. Only display the notice if the function is actually hooked to `edit_f…

    …orm_after_title`.
    
    This prevents the notice from displaying twice if the notice has already been moved to the `admin_notices` hook (as would happen in https://core.trac.wordpress.org/attachment/ticket/45057/45057.diff).
    desrosj committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    0db1eae View commit details
    Browse the repository at this point in the history