Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreliable link test #13161

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Fix unreliable link test #13161

merged 2 commits into from
Apr 16, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jan 2, 2019

Attempts to fix #13044. This failure only happens in CI (unable to reproduce locally) hence this PR

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@talldan talldan added the [Status] In Progress Tracking issues with work in progress label Jan 2, 2019
@talldan talldan self-assigned this Jan 2, 2019
@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Feb 7, 2019
@talldan talldan changed the title WIP Fix unreliable link test Fix unreliable link test Apr 15, 2019
@talldan talldan added this to the 5.5 (Gutenberg) milestone Apr 15, 2019
@talldan talldan removed the [Status] In Progress Tracking issues with work in progress label Apr 15, 2019
@talldan
Copy link
Contributor Author

talldan commented Apr 15, 2019

Hey @gziolo - I haven't really done any more to fix this one beyond a few changes to the test code. I wasn't able to work out why it was failing.

However, over the last 1-2 weeks I've been running the tests on travis in this branch on a daily basis, and I haven't seen a single failure of the test in question. I wonder if other code changes have resulted in this test becoming more stable 🤔

I think it might be worth trying to reintroduce the test— we can always disable it again if we see some failures.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reintroduce this test then :)

@talldan talldan merged commit 5d14c98 into master Apr 16, 2019
@talldan talldan deleted the fix/unreliable-link-test branch April 16, 2019 01:27
@youknowriad
Copy link
Contributor

This is still failing in several PRs for me. Let's disable all the unstable tests we find.

@@ -267,7 +267,7 @@ describe( 'Links', () => {

// Test for regressions of https://github.com/WordPress/gutenberg/issues/10496.
// Disabled until improved as it wasn't reliable enough.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should have been removed.

@aduth
Copy link
Member

aduth commented Apr 18, 2019

This is still failing in several PRs for me. Let's disable all the unstable tests we find.

See #15059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: Enable a disabled fragile link e2e test
5 participants